Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ship @babel/standalone source maps #14863

Merged
merged 5 commits into from Aug 31, 2022
Merged

ship @babel/standalone source maps #14863

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0b4a92c
ship @babel/standalone source maps
JLHwung Aug 18, 2022
3f973bd
pack Makefile.js
JLHwung Aug 18, 2022
8defa04
store source map in circleci builds
JLHwung Aug 18, 2022
50877e7
build sourcemap on circleci
JLHwung Aug 18, 2022
6ce0dba
fix sourcemap
liuxingbaoyu Aug 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 9 additions & 1 deletion .circleci/config.yml
View file
Open in desktop
Expand Up @@ -12,9 +12,15 @@ aliases:
- &artifact_babel
path: ~/babel/packages/babel-standalone/babel.js

- &artifact_babel_sourcemap
path: ~/babel/packages/babel-standalone/babel.js.map

- &artifact_babel_min
path: ~/babel/packages/babel-standalone/babel.min.js

- &artifact_babel_min_sourcemap
path: ~/babel/packages/babel-standalone/babel.min.js.map

- &test262_workdir
working_directory: ~/babel/babel-test262-runner

Expand All @@ -41,12 +47,14 @@ jobs:
- restore_cache: *restore-yarn-cache
# Builds babel-standalone with the regular Babel config
# test-ci-coverage doesn't test babel-standalone, as trying to gather coverage
- run: IS_PUBLISH=true make -j build-standalone-ci
- run: NODE_ENV=production IS_PUBLISH=true make -j build-standalone-ci
# data for a JS file that's several megabytes large is bound to fail. Here,
# we just run the babel-standalone test separately.
- run: yarn jest "\-standalone/test"
- store_artifacts: *artifact_babel
- store_artifacts: *artifact_babel_sourcemap
- store_artifacts: *artifact_babel_min
- store_artifacts: *artifact_babel_min_sourcemap
- save_cache: *save-yarn-cache

test262:
Expand Down
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Expand Up @@ -71,6 +71,7 @@ package-lock.json
packages/babel-standalone/babel.js
packages/babel-standalone/babel.js.map
packages/babel-standalone/babel.min.js
packages/babel-standalone/babel.min.js.map
/codemods/*/lib
/packages/babel-parser/build
.idea/
Expand Down
2 changes: 1 addition & 1 deletion Makefile.js
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions Makefile.source.mjs
View file
Open in desktop
Expand Up @@ -259,6 +259,7 @@ target["prepublish-build"] = function () {
target["prepublish-prepare-dts"]();
},
{
NODE_ENV: "production",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we unify NODE_ENV into BABEL_ENV? There is currently only one place where NODE_ENV is used, and there are more BABEL_ENV.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you open a PR to replace both? 🙏

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. I'll do this after 7.19.0 is released, it's a little messy and I'm worried about causing accidents.

STRIP_BABEL_8_FLAG: "true",
}
);
Expand Down
4 changes: 3 additions & 1 deletion packages/babel-standalone/package.json
View file
Open in desktop
Expand Up @@ -5,7 +5,9 @@
"main": "./babel.js",
"files": [
"babel.js",
"babel.min.js"
"babel.js.map",
"babel.min.js",
"babel.min.js.map"
],
"devDependencies": {
"@babel/core": "workspace:^",
Expand Down