chore: Speed up lint-staged

[liuxingbaoyu]

Q	A
License	MIT

Even without any caching, submitting a JS file was able to drop from 8.3 seconds to 2.6 seconds.

[babel-bot]

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52853/

[liuxingbaoyu]

Also I found that an overly complex babel.config caused babel-core to start very slowly, with two seconds spent loading the config when lint in our repository.
I think we can improve this in the future by increasing the speed or adding more hints.
For example, to allow output of plugin load times, or to add the expected caller option, allowing the user to pass in ["*"] or ["caller1","caller2"], otherwise output a prompt to let the user notice .

[nicolo-ribaudo]

Suggested change

	./node_modules/.bin/lint-staged --config package.json --no-stash
	yarn lint-staged --config package.json --no-stash

[liuxingbaoyu]

PS F:\babel> Measure-Command {yarn lint-staged}  

Days              : 0
Hours             : 0
Minutes           : 0
Seconds           : 2
Milliseconds      : 773
Ticks             : 27731558
TotalDays         : 3.20967106481481E-05
TotalHours        : 0.000770321055555556
TotalMinutes      : 0.0462192633333333
TotalSeconds      : 2.7731558
TotalMilliseconds : 2773.1558


PS F:\babel> Measure-Command {./node_modules/.bin/lint-staged}

Days              : 0
Hours             : 0
Minutes           : 0
Seconds           : 0
Milliseconds      : 454
Ticks             : 4540090
TotalDays         : 5.2547337962963E-06
TotalHours        : 0.000126113611111111
TotalMinutes      : 0.00756681666666667
TotalSeconds      : 0.454009
TotalMilliseconds : 454.009

yarn adds an extra 2s, which I tend to avoid.

[nicolo-ribaudo]

Oh ok. I'm surprised that it's this slow just to load a script.

[liuxingbaoyu]

Yeah, this seems to be brought by yarn3, which creates a new virtual environment for all commands.

[JLHwung]

FYI here is my benchmark results

time yarn lint-staged
→ No staged files found.
yarn lint-staged  0.62s user 0.10s system 114% cpu 0.634 total

time ./node_modules/.bin/lint-staged
→ No staged files found.
./node_modules/.bin/lint-staged  0.17s user 0.04s system 70% cpu 0.285 total

I am good either way if the startup time is less than 1 sec, but the Windows platform performance is a bit annoying. Maybe yarn PnP will save us some time here? /cc @merceyz

[liuxingbaoyu]

Merge it first?

[merceyz]

@JLHwung If the startup time in this case is just Yarn it probably wont help, we are aware of the issue though.
Ref yarnpkg/berry#2575

[JLHwung]

Instead of caller detection in Babel config, can we disable the whole Babel config loading in

babel/eslint/babel-eslint-config-internal/index.js

Line 7 in 1516a42

sourceType: "module",

?

See also https://github.com/babel/babel/tree/main/eslint/babel-eslint-parser#additional-parser-configuration