New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ts] allow redeclaring a var/type with the same name as import #14900
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52907/ |
Seems to expose another bug? |
It seems to me that |
Yes, it seems we can fix the original problem at the same time, which is to treat import as a new type. |
0c73e9b
to
52ed9c7
Compare
I haven't written complex ts types, it would be great if someone could help add some tests!😃
looks good! |
74f5269
to
109f488
Compare
That's great! Can you run |
OK, I'll do this after the review is complete. |
ff6e985
to
d083373
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Please don't merge yet, I found that the allowlist comment seems to be missing a bit, I'll take a look later. |
Too late 😬 |
Nevermind, I will open a new PR.😃 |
Doesn't seem to fix the original issue, but fixes #10015 (comment)Also found new similar bugs, this is in the second commit.
Not sure if
flow
is affected, but I guess I can ignore it for now.This also fixes #14795 which has been closed.
repl
repl2