Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid fancy stack traces size computation #14930

Merged
merged 2 commits into from Sep 14, 2022
Merged

Avoid fancy stack traces size computation #14930

merged 2 commits into from Sep 14, 2022

Commits on Sep 14, 2022

  1. Avoid fancy stack traces size computation 

    This will end up with the actual number of frames not exactly matching the user-set Error.stackTraceLimit. However, Error.stackTraceLimit is usually set to generic numbers (10, 100, 1000, Infinity), and it does not matter if it's not _really_ X but a bit less or more.

(How long before we get a bug report "Hey, I use Error.stackTraceLimit=1562 but it's only giving me 1543 frames!"?)
    @nicolo-ribaudo
    nicolo-ribaudo committed Sep 14, 2022
    Copy the full SHA
    c1d94e5 View commit details
    Browse the repository at this point in the history

  2. Don't modify 0

    @nicolo-ribaudo
    nicolo-ribaudo committed Sep 14, 2022
    Copy the full SHA
    3c40231 View commit details
    Browse the repository at this point in the history