New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve source map generation #14967
Changes from 7 commits
aeab923
4c4ac39
a3038b7
d90f6ec
7ef541c
28cc7de
2949354
3eaf31c
d23bc56
ca34bac
d32a7a8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -55,7 +55,7 @@ | |
"column": 4 | ||
}, | ||
"original": { | ||
"line": 90, | ||
"line": 92, | ||
"column": 0 | ||
} | ||
}, | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,11 @@ | ||
{ | ||
"mappings": "AAAA,UAAU,Y;SAAM;AAAC,CAAjB", | ||
"version": 3, | ||
"mappings": "AAAA,UAAU,Y;SAAM,C;CAAC", | ||
"names": [], | ||
"sources": ["original.js"], | ||
"sourcesContent": ["var foo = () => 4;"], | ||
"version": 3 | ||
} | ||
"sources": [ | ||
"original.js" | ||
], | ||
"sourcesContent": [ | ||
"var foo = () => 4;" | ||
] | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,13 @@ | ||
{ | ||
"version": 3, | ||
"mappings": "AAAC,KCAD;ACAA,K", | ||
"mappings": "AAAC,KAAG;ACAJ,KAAG", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change is fine. The |
||
"names": [], | ||
"sources": [ | ||
"bar.js", | ||
"input.tsx", | ||
"baz.js" | ||
], | ||
"sourcesContent": [ | ||
"<bar />", | ||
"foo(1);\nfunction foo(bar: number): never {\n throw new Error('Intentional.');\n}", | ||
"baz();" | ||
] | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"version": 3, | ||
"mappings": "AAAC,KCAD;;AACA,SAASA,GAAT,CAAaC,GAAb,EAAwB;EACpB,MAAM,IAAIC,KAAJ,CAAU,cAAV,CAAN;AACH", | ||
"mappings": "AAAC,KAAG;;ACCJ,SAASA,GAAG,CAACC,GAAW;EACpB,MAAM,IAAIC,KAAK,CAAC,cAAc,CAAC;AACnC", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Changes are fine. Same reasoning with the |
||
"names": [ | ||
"foo", | ||
"bar", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,11 @@ | ||
{ | ||
"mappings": "AAAA,UAAU,Y;SAAM;AAAC,CAAjB", | ||
"version": 3, | ||
"mappings": "AAAA,UAAU,Y;SAAM,C;CAAC", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same |
||
"names": [], | ||
"sources": ["source-maps/input-source-map-same-location/input.js"], | ||
"sourcesContent": ["var foo = () => 4;"], | ||
"version": 3 | ||
} | ||
"sources": [ | ||
"source-maps/input-source-map-same-location/input.js" | ||
], | ||
"sourcesContent": [ | ||
"var foo = () => 4;" | ||
] | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,11 @@ | ||
{ | ||
"version": 3, | ||
"mappings": "AAAC,KCAD", | ||
"mappings": "AAAC,KAAG", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same |
||
"names": [], | ||
"sources": [ | ||
"test.js", | ||
"input.tsx" | ||
"test.js" | ||
], | ||
"sourcesContent": [ | ||
"<bar />", | ||
"foo(1);\nfunction foo(bar: number): never {\n throw new Error('Intentional.');\n}" | ||
"<bar />" | ||
] | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,11 @@ | ||
{ | ||
"mappings": "AAAA,UAAU,Y;SAAM;AAAC,CAAjB", | ||
"version": 3, | ||
"mappings": "AAAA,UAAU,Y;SAAM,C;CAAC", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same |
||
"names": [], | ||
"sources": ["original.js"], | ||
"sourcesContent": ["var foo = () => 4;"], | ||
"version": 3 | ||
} | ||
"sources": [ | ||
"original.js" | ||
], | ||
"sourcesContent": [ | ||
"var foo = () => 4;" | ||
] | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
{ | ||
"mappings": "AAAA;AAEAA,OAAO,CAACC,GAAR,CAAY,eAAZ", | ||
"version": 3, | ||
"names": [ | ||
"console", | ||
"log" | ||
|
@@ -10,5 +10,5 @@ | |
"sourcesContent": [ | ||
"#!env node\n\nconsole.log(\"Hello, world!\");" | ||
], | ||
"version": 3 | ||
} | ||
"mappings": "AAAA;AAEAA,OAAO,CAACC,GAAG,CAAC,eAAe,CAAC" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The better maps the |
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is fine. The
;
is no longer mapped to a source location, which really don't matter.