Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve module expression parsing/printing #14980

Merged
merged 8 commits into from Sep 30, 2022
Merged

Improve module expression parsing/printing #14980

merged 8 commits into from Sep 30, 2022

Commits on Sep 30, 2022

  1. fix: several ModuleExpression printing edgecases

    @JLHwung
    JLHwung committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    5dba903 View commit details
    Browse the repository at this point in the history

  2. fix: end module expression's program before }

    @JLHwung
    JLHwung committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    101cad5 View commit details
    Browse the repository at this point in the history

  3. fix: expect braceL after module

    @JLHwung
    JLHwung committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    f31ab0f View commit details
    Browse the repository at this point in the history

  4. refactor: introduce ensureNoLineTerminator

    @JLHwung
    JLHwung committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    5215c61 View commit details
    Browse the repository at this point in the history

  5. use this.ensureNoLineTerminator

    @JLHwung
    JLHwung committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    5c60588 View commit details
    Browse the repository at this point in the history

  6. update source-map fixtures

    @JLHwung
    JLHwung committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    0dc2ccc View commit details
    Browse the repository at this point in the history

  7. address review comments

    @JLHwung
    JLHwung committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    1ec194d View commit details
    Browse the repository at this point in the history

  8. consume eof when end is eof

    @JLHwung
    JLHwung committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    199f8e5 View commit details
    Browse the repository at this point in the history