Fix(estree): Reset export's start after decorator #15107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
commented
Oct 31, 2022
| @@ -1073,32 +1099,6 @@ describe("verify", () => { | |||
| }); | |||
|
|
|||
| describe("decorators #72 (legacy)", () => { | |||
| function verifyDecoratorsLegacyAndAssertMessages( | |||
There was a problem hiding this comment.
This helper is moved to the top level.
| "body": [ | ||
| { | ||
| "type": "ExportNamedDeclaration", | ||
| "start":5,"end":22,"loc":{"start":{"line":1,"column":5},"end":{"line":1,"column":22}}, |
There was a problem hiding this comment.
When estree is enabled, we restore the pre-7.20 behaviour: the ExportNamedDeclaration now starts at the export token.
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/53307/ |
liuxingbaoyu
approved these changes
Nov 1, 2022
nicolo-ribaudo
approved these changes
Nov 1, 2022
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we partially reverts #15032 when
estreeplugin is enabled, so that the legacy syntax@dec export default class {}still work with thekeyword-spacingrule.