Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support await as for-of-lhs #15134

Merged
merged 1 commit into from Nov 5, 2022
Merged

fix: support await as for-of-lhs #15134

merged 1 commit into from Nov 5, 2022

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Nov 4, 2022

Q                       A
Fixed Issues? Fixes #15127
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

In this PR we mark await of ... as an ambiguous await expression, so we don't try to parse an await expression in for (await of []) in order to throw a better error message. This issue is a regression introduced in #12520.

@JLHwung JLHwung added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: parser labels Nov 4, 2022
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/53360/

@JLHwung JLHwung merged commit ce09a26 into babel:main Nov 5, 2022
@JLHwung JLHwung deleted the fix-15127 branch November 5, 2022 13:10
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Feb 5, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Babel crashes when using await as an identifier in ForInOfHead
4 participants