Don't convert line comments containing */ to block comments
#15135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuxingbaoyu
added
PR: Bug Fix 🐛
liuxingbaoyu
commented
Nov 5, 2022
| @@ -10,7 +10,6 @@ export function _params( | |||
| this.token("("); | |||
| this._parameters(node.params, node); | |||
| this.token(")"); | |||
| this._noLineTerminator = true; | |||
There was a problem hiding this comment.
This is the fix, can you confirm it? I'm not sure about the purpose here.
@nicolo-ribaudo
There was a problem hiding this comment.
In arrow functions, ) cannot be followed by a newline.
There was a problem hiding this comment.
Probably it doesn't matter because inner comments in arrow functions would already be printer earlier.
liuxingbaoyu
commented
Nov 5, 2022
Comment on lines
-907
to
+914
| if (this._noLineTerminator && HAS_NEWLINE.test(comment.value)) { | ||
| const noLineTerminator = this._noLineTerminator; | ||
|
|
||
| if ( | ||
| noLineTerminator && | ||
| (HAS_NEWLINE.test(comment.value) || | ||
| HAS_BlOCK_COMMENT_END.test(comment.value)) | ||
| ) { |
There was a problem hiding this comment.
Here is the fix for the root cause, see the test.
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/53362/ |
nicolo-ribaudo
approved these changes
Nov 5, 2022
nicolo-ribaudo
changed the title
*/ to block comments
1 task
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regression: #15118