Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve generator behavior when comments:false #15173

Merged
merged 2 commits into from Nov 25, 2022
Merged

Improve generator behavior when comments:false #15173

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5862a17
improve
liuxingbaoyu Nov 9, 2022
ca65490
review
liuxingbaoyu Nov 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/babel-generator/src/index.ts
View file
Open in desktop
Expand Up @@ -109,6 +109,16 @@ function normalizeOptions(
format.indent.adjustMultilineComment = false;
}

const { auxiliaryCommentBefore, auxiliaryCommentAfter, shouldPrintComment } =
format;

if (auxiliaryCommentBefore && !shouldPrintComment(auxiliaryCommentBefore)) {
format.auxiliaryCommentBefore = undefined;
}
if (auxiliaryCommentAfter && !shouldPrintComment(auxiliaryCommentAfter)) {
format.auxiliaryCommentAfter = undefined;
}

Comment on lines +112 to +121
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since shouldPrintComment does not pass any information other than the comment content, it is safe to call it only once.

return format;
}

Expand Down
52 changes: 26 additions & 26 deletions packages/babel-generator/src/printer.ts
View file
Open in desktop
Expand Up @@ -903,35 +903,35 @@ class Printer {
}
}

// Returns `true` if the comment cannot be printed in this position due to
// Returns `-1` if the comment cannot be printed in this position due to
// line terminators, signaling that the print comments loop can stop and
// resume printing comments at the next posisble position. This happens when
// resume printing comments at the next possible position. This happens when
// printing inner comments, since if we have an inner comment with a multiline
// there is at least one inner position where line terminators are allowed.
_printComment(
comment: t.Comment,
skipNewLines: COMMENT_SKIP_NEWLINE,
): boolean {
_shouldPrintComment(comment: t.Comment): -1 | 0 | 1 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use a const enum for the return type?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't come up with names that were short and clear enough, do you have any suggestions?

Copy link
Contributor

@JLHwung JLHwung Nov 14, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe

const enum PrintCommentHint {
  Discard,
  Allow,
  Defer
}

?

// Some plugins (such as flow-strip-types) use this to mark comments as removed using the AST-root 'comments' property,
// where they can't manually mutate the AST node comment lists.
if (comment.ignore) return false;
if (comment.ignore) return 0;

if (this._printedComments.has(comment)) return false;

const noLineTerminator = this._noLineTerminator;
if (this._printedComments.has(comment)) return 0;

if (
noLineTerminator &&
this._noLineTerminator &&
(HAS_NEWLINE.test(comment.value) ||
HAS_BlOCK_COMMENT_END.test(comment.value))
) {
return true;
return -1;
}

if (!this.format.shouldPrintComment(comment.value)) return false;

this._printedComments.add(comment);

if (!this.format.shouldPrintComment(comment.value)) return 0;

return 1;
}

_printComment(comment: t.Comment, skipNewLines: COMMENT_SKIP_NEWLINE) {
const noLineTerminator = this._noLineTerminator;
const isBlockComment = comment.type === "CommentBlock";

// Add a newline before and after a block comment, unless explicitly
Expand Down Expand Up @@ -999,8 +999,6 @@ class Printer {
if (printNewLines && skipNewLines !== COMMENT_SKIP_NEWLINE.SKIP_TRAILING) {
this.newline(1);
}

return false;
}

_printComments(
Expand All @@ -1025,8 +1023,12 @@ class Printer {
for (let i = 0; i < len; i++) {
const comment = comments[i];

const printed = this._printedComments.has(comment);
if (hasLoc && comment.loc && !printed) {
const shouldPrint = this._shouldPrintComment(comment);
if (shouldPrint === -1) {
hasLoc = false;
break;
}
if (hasLoc && comment.loc && shouldPrint === 1) {
const commentStartLine = comment.loc.start.line;
const commentEndLine = comment.loc.end.line;
if (type === COMMENT_TYPE.LEADING) {
Expand Down Expand Up @@ -1061,7 +1063,7 @@ class Printer {
lastLine = commentEndLine;

maybeNewline(offset);
if (this._printComment(comment, COMMENT_SKIP_NEWLINE.SKIP_ALL)) break;
this._printComment(comment, COMMENT_SKIP_NEWLINE.SKIP_ALL);

if (i + 1 === len) {
maybeNewline(Math.min(1, nodeEndLine - lastLine)); // TODO: Improve here when inner comments processing is stronger
Expand All @@ -1077,8 +1079,9 @@ class Printer {
}
} else {
hasLoc = false;

if (printed) continue;
if (shouldPrint !== 1) {
continue;
}

if (len === 1) {
const singleLine = comment.loc
Expand All @@ -1100,9 +1103,7 @@ class Printer {
: COMMENT_SKIP_NEWLINE.DEFAULT,
);
} else if (shouldSkipNewline && type === COMMENT_TYPE.TRAILING) {
if (this._printComment(comment, COMMENT_SKIP_NEWLINE.SKIP_ALL)) {
break;
}
this._printComment(comment, COMMENT_SKIP_NEWLINE.SKIP_ALL);
} else {
this._printComment(comment, COMMENT_SKIP_NEWLINE.DEFAULT);
}
Expand All @@ -1117,15 +1118,14 @@ class Printer {
// /*:: b: ?string*/
// }

const skippedDueToNewline = this._printComment(
this._printComment(
comment,
i === 0
? COMMENT_SKIP_NEWLINE.SKIP_LEADING
: i === len - 1
? COMMENT_SKIP_NEWLINE.SKIP_TRAILING
: COMMENT_SKIP_NEWLINE.DEFAULT,
);
if (skippedDueToNewline) break;
} else {
this._printComment(comment, COMMENT_SKIP_NEWLINE.DEFAULT);
}
Expand Down
4 changes: 1 addition & 3 deletions packages/babel-generator/test/fixtures/regression/15161/output.js
View file
Open in desktop
@@ -1,3 +1 @@
var test = (
) => {
};
var test = () => {};