Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix .parentPath after rename in SwitchCase #15287

Merged
merged 3 commits into from Dec 19, 2022
Merged

Fix .parentPath after rename in SwitchCase #15287

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e71bb6b
Add failing test for `.parentPath` after rename in `SwitchCase`
nicolo-ribaudo Dec 16, 2022
5549888
Fix
nicolo-ribaudo Dec 16, 2022
0ca02b3
Update packages/babel-traverse/src/scope/lib/renamer.ts
nicolo-ribaudo Dec 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 20 additions & 0 deletions packages/babel-traverse/test/scope.js
View file
Open in desktop
Expand Up @@ -1002,4 +1002,24 @@ describe("scope", () => {
expect(program.scope.hasOwnBinding("ref")).toBe(true);
});
});

describe("rename", () => {
it(".parentPath after renaming variable in switch", () => {
const program = getPath(`
switch (x) {
case y:
let a;
}
`);
program.traverse({
VariableDeclaration(path) {
if (path.node.declarations[0].id.name !== "a") return;

expect(path.parentPath.type).toBe("SwitchCase");
path.scope.rename("a");
expect(path.parentPath.type).toBe("SwitchCase");
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is currently SwitchStatement on main.

},
});
});
});
});