Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix indentation when retainLines is true #15569

Merged
merged 2 commits into from May 15, 2023
Merged

Fix indentation when retainLines is true #15569

merged 2 commits into from May 15, 2023

Conversation

liuxingbaoyu
Copy link
Member

@liuxingbaoyu liuxingbaoyu commented Apr 14, 2023 •
edited by gitpod-io bot

Q                       A
Fixed Issues? #15515 (comment)
Patch: Bug Fix? √
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? √
Documentation PR Link
Any Dependency Changes?
License MIT

Based on #15515, please review the last commit.

@liuxingbaoyu liuxingbaoyu added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: generator labels Apr 14, 2023
@babel-bot
Copy link
Collaborator

babel-bot commented Apr 14, 2023 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/54416/

nicolo-ribaudo
nicolo-ribaudo approved these changes May 15, 2023
View reviewed changes
packages/babel-generator/src/printer.ts Outdated Show resolved Hide resolved
@nicolo-ribaudo nicolo-ribaudo changed the title fix: Indentation when retainLines Fix indentation when retainLines is true May 15, 2023
@JLHwung JLHwung merged commit 1e6551f into babel:main May 15, 2023
54 checks passed
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Aug 15, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: generator PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@liuxingbaoyu @babel-bot @JLHwung @nicolo-ribaudo