fix: Works correctly with --frozen-intrinsics

[liuxingbaoyu]

Q	A
Fixed Issues?	Fixes #15625
Patch: Bug Fix?	√
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass?	√
Documentation PR Link
Any Dependency Changes?
License	MIT

[babel-bot]

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/54577/

[nicolo-ribaudo]

Suggested change

	if (desc === undefined) {
	return Object.isExtensible(Error);
	}
	return Object.prototype.hasOwnProperty.call(desc, "writable")
	? desc.writable
	: desc.set !== undefined;
	return desc && Object.prototype.hasOwnProperty.call(desc, "writable") && desc.writable;

Do you think this would be enough? Since stackTraceLimit is only supported by V8, and:

• if the property doesn't exist, there is no reason to set it because we are in a different engine
• in V8 it's a data property, not a setter

[liuxingbaoyu]

in V8 it's a data property, not a setter

Is it possible for the user to set it to have no setter?

[nicolo-ribaudo]

Yes, but it disables .stack generation:

➜ node
Welcome to Node.js v20.0.0.
Type ".help" for more information.
> Error.stackTraceLimit = 2
2
> new Error().stack
'Error\n    at REPL8:1:1\n    at Script.runInThisContext (node:vm:122:12)'
> let limit = 3;
undefined
> Object.defineProperty(Error, "stackTraceLimit", { get: () => limit, set: v => limit = v })
[Function: Error] { stackTraceLimit: [Getter/Setter] }
> Error.stackTraceLimit
3
> new Error().stack
undefined
> 

[liuxingbaoyu]

@nicolo-ribaudo Thanks! Yes I'm doing both locally. :)

[nicolo-ribaudo]

I would love to see a PR using itGte in more places :)