New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set shorthand: false
when renaming an identifier inside an object property
#15649
Merged
nicolo-ribaudo
merged 5 commits into
babel:main
from
coderaiser:feature/set-shorthand-when-rename-identifier-inside-object-property
May 29, 2023
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e4d4746
feature: babel-traverse: set shorthand when rename Identifier inside …
coderaiser d6c01d3
feature: babel-traverse: shorthand of ObjectProperty (#15648)
coderaiser 961233c
test: babel-preset-env: update fixture
coderaiser e039d8e
Fix bug
nicolo-ribaudo a7728f2
misc
liuxingbaoyu File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could:
program.traverse
call, to be 100% sure that it runs (I know you copied this pattern from the test above, but we can do better 🙂).toBeFalsy()
with.toBe(false)
(since we expect false and not any falsy value)expect(program.toString()).toMatchInlineSnapshot()
at the end, which helps when reading the tests to more easily see what's happeningAlso, it would be good to have the following tests:
const a = 1, obj = { a };
, renaminga
const { a } = 1; { const { b } = 2 }
renaminga
tob
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did another fix locally.
I don't think it's necessary to traverse twice to fix this, just add the
ObjectProperty
visitor.At the same time I also found a strange thing, we also have an
extra.shorthand
in the AST, I don't understand why.🤔