Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix importing symbol polyfill in @babel/runtime-corejs2 #15660

Merged
merged 2 commits into from May 26, 2023
Merged

Fix importing symbol polyfill in @babel/runtime-corejs2 #15660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d2fad3
Update `babel-plugin-polyfill-corejs2`
nicolo-ribaudo May 26, 2023
36a2d01
Update tests
nicolo-ribaudo May 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/babel-plugin-transform-runtime/package.json
View file
Open in desktop
Expand Up @@ -22,7 +22,7 @@
"dependencies": {
"@babel/helper-module-imports": "workspace:^",
"@babel/helper-plugin-utils": "workspace:^",
"babel-plugin-polyfill-corejs2": "^0.4.1",
"babel-plugin-polyfill-corejs2": "^0.4.2",
"babel-plugin-polyfill-corejs3": "^0.8.1",
"babel-plugin-polyfill-regenerator": "^0.5.0",
"semver": "condition:BABEL_8_BREAKING ? ^7.3.4 : ^6.3.0"
Expand Down
2 changes: 1 addition & 1 deletion ...bel-plugin-transform-runtime/test/fixtures/runtime-corejs2/aliased-constructors/output.js
View file
Open in desktop
@@ -1,5 +1,5 @@
var _Promise = require("@babel/runtime-corejs2/core-js/promise");
var _Symbol = require("@babel/runtime-corejs2/core-js/symbol");
var _Symbol = require("@babel/runtime-corejs2/core-js/symbol/index");
var _Map = require("@babel/runtime-corejs2/core-js/map");
obj.constructor === Object;
obj.constructor === _Promise;
Expand Down
2 changes: 1 addition & 1 deletion packages/babel-plugin-transform-runtime/test/fixtures/runtime-corejs2/full/output.mjs
View file
Open in desktop
@@ -1,6 +1,6 @@
import _regeneratorRuntime from "@babel/runtime-corejs2/helpers/regeneratorRuntime";
var _marked = /*#__PURE__*/_regeneratorRuntime().mark(giveWord);
import _Symbol from "@babel/runtime-corejs2/core-js/symbol";
import _Symbol from "@babel/runtime-corejs2/core-js/symbol/index";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seem to be some issues here.🤦‍♂️
This appears to be an invalid path.

image
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ushhh thanks for catching this

import foo, * as bar from "someModule";
export const myWord = _Symbol("abc");
export function giveWord() {
Expand Down
2 changes: 1 addition & 1 deletion packages/babel-preset-env/package.json
View file
Open in desktop
Expand Up @@ -91,7 +91,7 @@
"@babel/plugin-transform-unicode-sets-regex": "workspace:^",
"@babel/preset-modules": "^0.1.5",
"@babel/types": "workspace:^",
"babel-plugin-polyfill-corejs2": "^0.4.1",
"babel-plugin-polyfill-corejs2": "^0.4.2",
"babel-plugin-polyfill-corejs3": "^0.8.1",
"babel-plugin-polyfill-regenerator": "^0.5.0",
"core-js-compat": "^3.30.2",
Expand Down
2 changes: 1 addition & 1 deletion packages/babel-runtime-corejs2/helpers/esm/iterableToArray.js
View file
Open in desktop
@@ -1,4 +1,4 @@
import _Symbol from "core-js/library/fn/symbol.js";
import _Symbol from "core-js/library/fn/symbol/index.js";
import _Symbol$iterator from "core-js/library/fn/symbol/iterator.js";
import _Array$from from "core-js/library/fn/array/from.js";
export default function _iterableToArray(iter) {
Expand Down
2 changes: 1 addition & 1 deletion packages/babel-runtime-corejs2/helpers/iterableToArray.js
View file
Open in desktop
@@ -1,4 +1,4 @@
var _Symbol = require("core-js/library/fn/symbol.js");
var _Symbol = require("core-js/library/fn/symbol/index.js");
var _Symbol$iterator = require("core-js/library/fn/symbol/iterator.js");
var _Array$from = require("core-js/library/fn/array/from.js");
function _iterableToArray(iter) {
Expand Down
2 changes: 1 addition & 1 deletion packages/babel-runtime-corejs2/helpers/typeof.js
View file
Open in desktop
@@ -1,4 +1,4 @@
var _Symbol = require("core-js/library/fn/symbol.js");
var _Symbol = require("core-js/library/fn/symbol/index.js");
var _Symbol$iterator = require("core-js/library/fn/symbol/iterator.js");
function _typeof(obj) {
"@babel/helpers - typeof";
Expand Down
12 changes: 6 additions & 6 deletions yarn.lock
View file
Open in desktop
Expand Up @@ -3167,7 +3167,7 @@ __metadata:
"@babel/runtime-corejs3": "workspace:^"
"@babel/template": "workspace:^"
"@babel/types": "workspace:^"
babel-plugin-polyfill-corejs2: ^0.4.1
babel-plugin-polyfill-corejs2: ^0.4.2
babel-plugin-polyfill-corejs3: ^0.8.1
babel-plugin-polyfill-regenerator: ^0.5.0
make-dir: "condition:BABEL_8_BREAKING ? : ^2.1.0"
Expand Down Expand Up @@ -3581,7 +3581,7 @@ __metadata:
"@babel/preset-modules": ^0.1.5
"@babel/traverse": "workspace:^"
"@babel/types": "workspace:^"
babel-plugin-polyfill-corejs2: ^0.4.1
babel-plugin-polyfill-corejs2: ^0.4.2
babel-plugin-polyfill-corejs3: ^0.8.1
babel-plugin-polyfill-regenerator: ^0.5.0
core-js-compat: ^3.30.2
Expand Down Expand Up @@ -6096,16 +6096,16 @@ __metadata:
languageName: node
linkType: hard

"babel-plugin-polyfill-corejs2@npm:^0.4.1":
version: 0.4.1
resolution: "babel-plugin-polyfill-corejs2@npm:0.4.1"
"babel-plugin-polyfill-corejs2@npm:^0.4.2":
version: 0.4.2
resolution: "babel-plugin-polyfill-corejs2@npm:0.4.2"
dependencies:
"@babel/compat-data": ^7.17.7
"@babel/helper-define-polyfill-provider": ^0.4.0
semver: ^6.1.1
peerDependencies:
"@babel/core": ^7.0.0-0
checksum: f2b9bfec71914899b6e028441db565e1a2f2bc8208738c0fd7093e36fa6232cb803577751a745a0a30484928fcff65b3dad2c124bf9d956c3de19c26a1355a5e
checksum: 6a337c3ad16ebbf63e377ced3bb8be7db67c876ff51c26eea068bab73fc79dcf55a8c121ef45e220a0c7f08eaa975ac0556400987ce1ff48d76d8a46dd88c231
languageName: node
linkType: hard

Expand Down