Refactor visitors merging #15702
Merged
Refactor visitors merging #15702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/54785/ |
nicolo-ribaudo
added
the
PR: Internal 🏠
nicolo-ribaudo
approved these changes
Jun 29, 2023
| // @ts-expect-error Fixme: document state.key | ||
| newFn = wrapper(state.key, key, newFn); | ||
| // @ts-expect-error Fixme: actually PluginPass.key (aka pluginAlias)? | ||
| newFn = wrapper(state?.key, phase, newFn); |
There was a problem hiding this comment.
Can state be nullish? Or should this be state!.key? If it can be null, can you specify it in the state type signature?
Co-authored-by: liuxingbaoyu <30521560+liuxingbaoyu@users.noreply.github.com>
nicolo-ribaudo
force-pushed
the
traverse-merge
branch
from
881528e
to
70eaf38
Compare
nicolo-ribaudo
changed the title
1 task
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried to better type-polish
merge, not realizing there was already an open bug and attached PR; hence, there is the relevant test added, courtesy of @liuxingbaoyu on #15593.VisitPhaseExplodedVisitorwith internal flags attached