Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update compat-data sources #15726

Merged
merged 4 commits into from Jun 27, 2023
Merged

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Jun 27, 2023

Q                       A
Fixed Issues? The compat-data entry transform-export-namespace-from misses supported target deno. It also contains unsupported target and_chr
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes? Updated compat-data data sources
License MIT

In this PR we update the compat data sources and add the deno support data for the export-namespace-from feature. The unwanted entries is due to the fact that the data extracting logic is shared with the one of native-modules.json.

However, they are vastly different: The plugins.json expects target names defined in

while the native-modules.json expects browserslist target names, likely because it is supposed to be merged with user provided browserslist configs. In this PR we provide a new browser name map for this feature.

I mark this PR as bugfixes because the export-namespace-from feature is supposed to come with deno data.

The browserslist update is postponed as now browserslist returns correct opera mobile version but we still map it to the Opera desktop. I will fix that in another PR.

@JLHwung JLHwung added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: compat-data labels Jun 27, 2023
@babel-bot
Copy link
Collaborator

babel-bot commented Jun 27, 2023

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/54706/

@JLHwung JLHwung merged commit e827372 into babel:main Jun 27, 2023
55 of 56 checks passed
@JLHwung JLHwung deleted the update-compat-data-sources branch June 27, 2023 18:58
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Sep 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: compat-data PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants