Inject tmp vars in the params list of IIFEs when possible #15741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
PR: Output optimization 🔬
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/54752/ |
JLHwung
reviewed
Jul 3, 2023
liuxingbaoyu
approved these changes
Jul 3, 2023
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2When injecting a non-const non-initialized binding inside an IIFE, if the number of call arguments is less than or equal to the number of function parameters, we can safely inject the binding into the parameter list.
I copied this possible optimization from how ESBuild compiles optional chaining in function parameters :)
https://esbuild.github.io/try/#dAAwLjE4LjExAC0tdGFyZ2V0PWVzMjAxOQBmdW5jdGlvbiBmKHggPSBhKCk/LmIpIHt9