Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration tests for @angular/cli #15755

Merged
merged 8 commits into from Jul 6, 2023
Merged

Add integration tests for @angular/cli #15755

merged 8 commits into from Jul 6, 2023

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Jul 6, 2023 •
edited by gitpod-io bot

Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Ref #15754 (comment)

@babel-bot
Copy link
Collaborator

babel-bot commented Jul 6, 2023 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/54809/

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/54801/

liuxingbaoyu
liuxingbaoyu approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@liuxingbaoyu liuxingbaoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this!

@nicolo-ribaudo
Copy link
Member Author

Angular doesn't currently support our ESM build, I'm only enabling the other tests for now.

@nicolo-ribaudo
Copy link
Member Author

The reason the ESM tests are failing is that @angular-devkit/build-angular pins @babel/core to an older CommonJS version, and since the ESM version is published as 7.x in our tests it fails because it tries to import ESM deps.

@nicolo-ribaudo nicolo-ribaudo merged commit 733e2f6 into babel:main Jul 6, 2023
53 of 55 checks passed
@nicolo-ribaudo nicolo-ribaudo deleted the angluar-cli-e2e branch July 6, 2023 14:24
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 12, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@liuxingbaoyu liuxingbaoyu liuxingbaoyu approved these changes

Assignees
No one assigned
Labels
area: tests outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nicolo-ribaudo @babel-bot @liuxingbaoyu