Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recordAndTupleSyntaxType defaults to "hash" #15757

Merged
merged 2 commits into from Jul 6, 2023
Merged

recordAndTupleSyntaxType defaults to "hash" #15757

merged 2 commits into from Jul 6, 2023

Conversation

coderaiser
Copy link
Contributor

@coderaiser coderaiser commented Jul 6, 2023 •
edited

Q                       A
Fixed Issues? Fixes #15756
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Not sure how good this fix is, but for @babel/parser default syntax is hash:

image

So better to set it as default, then crash 🤷‍♂️.

@babel-bot
Copy link
Collaborator

babel-bot commented Jul 6, 2023 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/54814/

JLHwung
JLHwung approved these changes Jul 6, 2023
View reviewed changes
packages/babel-generator/src/index.ts Outdated Show resolved Hide resolved
nicolo-ribaudo
nicolo-ribaudo approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason that there was no default is that when we implemented support for R&T the proposal didn't settle on any syntax yet, but it seems clear that now it will use #.

@coderaiser @JLHwung
Update packages/babel-generator/src/index.ts
01f51a6 
Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>
@JLHwung JLHwung added PR: Polish 💅 A type of pull request used for our changelog categories pkg: generator labels Jul 6, 2023
@JLHwung JLHwung changed the title fix: TupleExpression to String (#15756) recordAndTupleSyntaxType defaults to "hash" Jul 6, 2023
@JLHwung JLHwung merged commit 61115d0 into babel:main Jul 6, 2023
57 checks passed
@coderaiser coderaiser deleted the fix/tuple-expression-to-string branch July 7, 2023 07:59
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: generator PR: Polish 💅 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Error: undefined is not a valid recordAndTuple syntax type
4 participants
@coderaiser @babel-bot @JLHwung @nicolo-ribaudo