fix: Infinity in enums
#15774
Merged
fix: Infinity in enums
#15774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
liuxingbaoyu
commented
Jul 11, 2023
•
liuxingbaoyu
commented
| Q | A |
|---|---|
| Fixed Issues? | Fixes #15768 |
| Patch: Bug Fix? | √ |
| Major: Breaking Change? | |
| Minor: New Feature? | |
| Tests Added + Pass? | √ |
| Documentation PR Link | |
| Any Dependency Changes? | |
| License | MIT |
liuxingbaoyu
added
PR: Bug Fix 🐛
liuxingbaoyu
commented
Jul 11, 2023
| StateEnum[StateEnum["pos"] = Infinity] = "pos"; | ||
| StateEnum[StateEnum["nan"] = NaN] = "nan"; | ||
| StateEnum[StateEnum["ext"] = 42] = "ext"; | ||
| StateEnum[StateEnum["ext2"] = 1] = "ext2"; |
There was a problem hiding this comment.
This is inconsistent with TS, if we want to align, it is most convenient to add a feature in traverse.
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/54834/ |
nicolo-ribaudo
approved these changes
Jul 12, 2023
| @@ -0,0 +1,11 @@ | |||
| const v = 42; | |||
| const v2 = Infinity; | |||
| var Infinity = 1; // Known inconsistencies | |||
There was a problem hiding this comment.
Note that in scripts this doesn't actually change the value of Infinity. However, there is another case in which it does and TS is not behaving as I would expect: microsoft/TypeScript#54981
JLHwung
approved these changes
Jul 12, 2023
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.