Use const enum in babel-parser #15793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
PR: Internal 🏠
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/54897/ |
nicolo-ribaudo
approved these changes
Jul 18, 2023
| SCOPE_VAR = SCOPE_PROGRAM | SCOPE_FUNCTION | SCOPE_STATIC_BLOCK | SCOPE_TS_MODULE; | ||
| /* eslint-disable prettier/prettier */ | ||
| export const enum ScopeFlag { | ||
| OTHER = 0b000000000, |
There was a problem hiding this comment.
Nit: can you vertically align them? It makes it easier to see the position of 1.
liuxingbaoyu
approved these changes
Jul 19, 2023
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we merge a few constant sets into TS const enum in the
@babel/parser. By doing so we can replace all enum usage by the actual bits, thanks to thebabelPluginInlineConstNumericObjectscustomized plugin, and enable TS to check union types effectively. For example I added a few binding types to thebindingTypesunion because previously it is resolved to a general number.