Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ts] Fix compiling extended exported nested namespace #15798

Merged
merged 1 commit into from Jul 20, 2023
Merged

[ts] Fix compiling extended exported nested namespace #15798

merged 1 commit into from Jul 20, 2023

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Jul 19, 2023 •
edited by gitpod-io bot

Q                       A
Fixed Issues? Fixes #15796
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

path.parentPath.replaceWith always causes bugs, because the traversal continues in a detached tree.

@nicolo-ribaudo nicolo-ribaudo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories area: typescript labels Jul 19, 2023
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/54902/

JLHwung
JLHwung approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR idea: we can make a custom ESLint rule to forbid the pattern path.parentPath.replace*.

@nicolo-ribaudo nicolo-ribaudo merged commit 12dfea7 into babel:main Jul 20, 2023
57 checks passed
@nicolo-ribaudo nicolo-ribaudo deleted the ts-export-ns-nested branch July 20, 2023 06:17
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung approved these changes

@liuxingbaoyu liuxingbaoyu liuxingbaoyu approved these changes

Assignees
No one assigned
Labels
area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: @babel/preset-typescript compile ts file error
4 participants
@nicolo-ribaudo @babel-bot @JLHwung @liuxingbaoyu