Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only allow developing Babel 8 in ESM mode #15816

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Only allow developing Babel 8 in ESM mode #15816

merged 2 commits into from
Aug 2, 2023

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Jul 24, 2023 •
edited by gitpod-io bot

Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This allows to use ESM dependencies in Babel 8, such as #15792

@babel-bot
Copy link
Collaborator

babel-bot commented Jul 24, 2023 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/54997/

@nicolo-ribaudo nicolo-ribaudo marked this pull request as draft July 24, 2023 14:42
@nicolo-ribaudo nicolo-ribaudo marked this pull request as ready for review July 24, 2023 16:08
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Jul 24, 2023
Merged
liuxingbaoyu
liuxingbaoyu reviewed Jul 25, 2023
View reviewed changes
packages/babel-core/src/index.ts
@@ -1,3 +1,13 @@
if (!process.env.IS_PUBLISH) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally prefer to put it in jest.config.js.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put it here because in local development I often import @babel/core directly, to see&debug behavior. This is stripped anyway on publish, but having the check here makes it work both with and without Jest in local development.

@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Jul 31, 2023
Merged
@nicolo-ribaudo
Copy link
Member Author

nicolo-ribaudo commented Jul 31, 2023 •
edited

CI timeout is unrelated (it tests Babel 7). I'm also unsure about the test262 failure.

@nicolo-ribaudo
Copy link
Member Author

I'm merging this since it blocks a bunch of other PRs.

@nicolo-ribaudo nicolo-ribaudo merged commit 48b05ac into babel:main Aug 2, 2023
49 of 50 checks passed
@nicolo-ribaudo nicolo-ribaudo deleted the ci-8-esm branch August 2, 2023 13:19
@nicolo-ribaudo
Copy link
Member Author

NOTE You can now only run with BABEL_8_BREAKING=true if you are developing in the monorepo in ESM mode. It's enough to run make use-esm once, and you can develop both Babel 7 and Babel 8 in ESM mode.

@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Aug 3, 2023
Merged
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 2, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@liuxingbaoyu liuxingbaoyu liuxingbaoyu left review comments

@JLHwung JLHwung JLHwung approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nicolo-ribaudo @babel-bot @JLHwung @liuxingbaoyu