Revert Node.js 20.6.0 bug workaround #15965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
the
PR: Revert ↩️
liuxingbaoyu
approved these changes
Sep 13, 2023
|
We need to wait at least until when CircleCI supports either 20.6.1 or 20.7.0: CircleCI-Public/cimg-node#355 |
JLHwung
approved these changes
Sep 13, 2023
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/55455/ |
|
CircleCI released 20.6.1: CircleCI-Public/cimg-node#358 |
|
Edit: ah, I see #15966 just now |
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 20.6.0 bug was fixed in 20.6.1, released 5 days ago. In addition to that, 20.7.0 is scheduled to be released today (nodejs/Release#855).
It should be safe to remove the workaround now, given that users can upgrade to 20.6.1 or 20.7.0. The workaround, while temporarily solved the huge breakage in the ecosystem, is now causing problems with multiple tools that are not configured to properly support CommonJS (i.e. they are parsing our released files as modules or as classic scripts without top-level return support).