Avoid dynamic dispatch when calling wrapCheck #16060
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Micro-optimization to avoid dynamic function dispatch in wrapCheck, which is in the hot path of babel transforms. The current code interpolates a string and looks up a function at runtime during every visitor function invocation, whereas this PR looks up the function once while building the visitor and just calls it during visitor function invocation.
I couldn't find any docs on babel benchmarking, so I used swc's benchmark and modified it to only run babel. Here are the before/after results:
Before:
After:
It's roughly a 5-6% improvement.