Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip type-only TS namespaces #16071

Merged
merged 1 commit into from Nov 6, 2023

Conversation

colinaaa
Copy link
Contributor

Q                       A
Fixed Issues? Fixes #15940
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

We move GLOBAL_TYPES-related codes into global-types.ts since we would like to share codes between index.ts and namespace.ts and we do not want to export these functions outside this package.

We move `GLOBAL_TYPES`-related codes into `global-types.ts` since we
would like to share codes between `index.ts` and `namespace.ts` and we
do not want to export these functions outside this package.

Change-Id: I833a7e1a63ee56e78db44b3a70953a280e0064be
Signed-off-by: Qingyu Wang <qingyu.wang@aliyun.com>
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/55731/

Copy link
Member

@liuxingbaoyu liuxingbaoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@liuxingbaoyu liuxingbaoyu added PR: Bug Fix 🐛 A type of pull request used for our changelog categories area: typescript labels Nov 5, 2023
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! :)

@nicolo-ribaudo nicolo-ribaudo changed the title Strip type-only TS namespace Strip type-only TS namespaces Nov 6, 2023
@nicolo-ribaudo nicolo-ribaudo merged commit b9d051a into babel:main Nov 6, 2023
47 of 48 checks passed
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Feb 6, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: @babel/preset-typescript@7.22.15 fails when exporting namespace
4 participants