Migrate `eslint-parser` to cts #16222

liuxingbaoyu · 2024-01-18T01:10:42Z

Q	A
Fixed Issues?	`Fixes #1, Fixes #2`
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass?	Yes
Documentation PR Link
Any Dependency Changes?
License	MIT

I'm using a lot of any in eslint/babel-eslint-parser/src/analyze-scope.cts because I was surprised that we even support scopes for both ts and flow and https://github.com/babel //pull/16210#issue-2076517615.

babel-bot · 2024-01-18T01:12:56Z

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/56184/

babel-bot · 2024-01-18T01:12:56Z

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/56147/

liuxingbaoyu · 2024-01-18T04:46:25Z

Unfortunately I can't make tsc happy.
If I set module to "ESNext", then ts complains that the type definition for "@typescript-eslint/scope-manager cannot be found.
If I set module to Node16, then ts will complain about import.meta.

eslint/babel-eslint-parser/src/convert/convertAST.cts

nicolo-ribaudo · 2024-01-18T10:30:25Z

eslint/babel-eslint-parser/src/configuration.cts

@@ -14,5 +16,5 @@ exports.normalizeESLintConfig = function (options) {
    sourceType,
    requireConfigFile,
    ...otherOptions,
-  };
+  } as Options;


Can we add it in the return type of the function rather than casting?

eslint/babel-eslint-parser/src/convert/convertComments.cts

eslint/babel-eslint-parser/src/convert/convertTokens.cts

nicolo-ribaudo · 2024-01-18T10:37:42Z

eslint/babel-eslint-parser/src/convert/index.cts

+import convertAST = require("./convertAST.cts");
+import type { AST, ParseResult } from "../types.cts";
+
+export function convertFile(


I like to think of TypeScript as "just adding types on top of otherwise untransformed JS code". Given that this file is meant to be CommonJS, would it be possible to do exports.convertFile = function (...) { ... }? Or does TS complain?

TS will complain about this. When we import, the type of function does not exist.

eslint/babel-eslint-parser/src/worker/index.cts

Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>

liuxingbaoyu · 2024-01-21T05:19:53Z

microsoft/TypeScript#56785
Fortunately, TS just added a feature.

liuxingbaoyu · 2024-01-21T05:22:56Z

tsconfig.base.json

    "esModuleInterop": true,
    "isolatedModules": true,
    "allowImportingTsExtensions": true,
-    "skipLibCheck": false,
+    "skipLibCheck": true,


node_modules/@types/node/events.d.ts:878:14 - error TS1291: 'events' resolves to a type and must be marked type-only in this file before re-exporting when 'isolatedModules' is enabled. Consider using 'import type' where 'events' is imported. 878 export = events; ~~~~~~ node_modules/@types/node/module.d.ts:314:14 - error TS1291: 'module' resolves to a type and must be marked type-only in this file before re-exporting when 'isolatedModules' is enabled. Consider using 'import type' where 'module' is imported. 314 export = module; ~~~~~~ node_modules/@types/node/stream.d.ts:1700:14 - error TS1291: 'stream' resolves to a type and must be marked type-only in this file before re-exporting when 'isolatedModules' is enabled. Consider using 'import type' where 'stream' is imported. 1700 export = stream; ~~~~~~ Found 3 errors.

@types/node is so popular that it not working is worrisome 😅 I know it's probably because we are using a pre-release, but I opened DefinitelyTyped/DefinitelyTyped#68285

It seems sufficient to mark the import assignment in @types/node as type only:

- import events = require("events"); + import type events = require("events");

Can we patch this library so we don't have to turn off the lib check?

to mark the import assignment in @types/node as type only

But it is not type only. It looks like a bug in TS

Fixed in TS: microsoft/TypeScript#57148

JLHwung · 2024-01-22T17:59:41Z

eslint/babel-eslint-parser/src/worker/maybeParse.cts

+import astInfo = require("./ast-info.cts");
+import extractParserOptionsPlugin = require("./extract-parser-options-plugin.cjs");
+
+import type { ConfigItem } from "../../../../packages/babel-core/src/config/item";


It should be imported from @babel/core.

nicolo-ribaudo · 2024-01-25T15:50:15Z

packages/babel-core/src/tools/build-external-helpers.ts

@@ -24,7 +24,7 @@ import {
 } from "@babel/types";
 import type * as t from "@babel/types";
 import File from "../transformation/file/file.ts";
-import type { PublicReplacements } from "@babel/template/src/options";
+import type { PublicReplacements } from "../../../babel-template/src/options.ts";


Is this intentional?

It is not exported and we accidentally referenced the internal file earlier.
I'm not sure if I want to export it.

It looks like we should export them.

Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@babel/traverse](https://babel.dev/docs/en/next/babel-traverse) ([source](https://github.com/babel/babel)) | resolutions | patch | [`7.23.7` -> `7.23.9`](https://renovatebot.com/diffs/npm/@babel%2ftraverse/7.23.7/7.23.9) | --- ### Release Notes <details> <summary>babel/babel (@babel/traverse)</summary> ### [`v7.23.9`](https://github.com/babel/babel/blob/HEAD/CHANGELOG.md#v7239-2024-01-25) [Compare Source](babel/babel@v7.23.7...v7.23.9) ##### 🐛 Bug Fix - `babel-helper-transform-fixture-test-runner`, `babel-plugin-transform-function-name`, `babel-plugin-transform-modules-systemjs`, `babel-preset-env` - [#16225](babel/babel#16225) fix: `systemjs` re-traverses helpers ([@liuxingbaoyu](https://github.com/liuxingbaoyu)) - `babel-helper-create-class-features-plugin`, `babel-plugin-proposal-decorators` - [#16226](babel/babel#16226) Improve decorated private method check ([@JLHwung](https://github.com/JLHwung)) - `babel-plugin-proposal-decorators`, `babel-plugin-transform-async-generator-functions`, `babel-plugin-transform-runtime`, `babel-preset-env` - [#16224](babel/babel#16224) Properly sort `core-js@3` imports ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - `babel-traverse` - [#15383](babel/babel#15383) fix: Don't throw in `getTypeAnnotation` when using TS+inference ([@liuxingbaoyu](https://github.com/liuxingbaoyu)) - Other - [#16210](babel/babel#16210) \[eslint] Fix `no-use-before-define` for class ref in fields ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) ##### 🏠 Internal - `babel-core`, `babel-parser`, `babel-template` - [#16222](babel/babel#16222) Migrate `eslint-parser` to cts ([@liuxingbaoyu](https://github.com/liuxingbaoyu)) - `babel-types` - [#16213](babel/babel#16213) Remove `@babel/types` props that are not produced by the parser ([@liuxingbaoyu](https://github.com/liuxingbaoyu)) ##### 🏃‍♀️ Performance - `babel-parser` - [#16072](babel/babel#16072) perf: Improve parser performance for typescript ([@liuxingbaoyu](https://github.com/liuxingbaoyu)) ##### 🔬 Output optimization - `babel-helper-create-class-features-plugin`, `babel-plugin-proposal-decorators`, `babel-plugin-proposal-destructuring-private`, `babel-plugin-proposal-pipeline-operator`, `babel-plugin-transform-class-properties`, `babel-plugin-transform-class-static-block`, `babel-plugin-transform-new-target`, `babel-plugin-transform-parameters`, `babel-plugin-transform-private-methods`, `babel-preset-env` - [#16218](babel/babel#16218) Improve temporary variables for decorators ([@liuxingbaoyu](https://github.com/liuxingbaoyu)) - `babel-helpers`, `babel-plugin-proposal-explicit-resource-management`, `babel-runtime-corejs2`, `babel-runtime-corejs3`, `babel-runtime` - [#15959](babel/babel#15959) Improve output of `using` ([@liuxingbaoyu](https://github.com/liuxingbaoyu)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.vylpes.xyz/RabbitLabs/random-bunny/pulls/142 Reviewed-by: Vylpes <ethan@vylpes.com> Co-authored-by: Renovate Bot <renovate@vylpes.com> Co-committed-by: Renovate Bot <renovate@vylpes.com>

liuxingbaoyu added PR: Internal 🏠 A type of pull request used for our changelog categories area: eslint labels Jan 18, 2024

nicolo-ribaudo reviewed Jan 18, 2024

View reviewed changes

liuxingbaoyu and others added 2 commits January 21, 2024 12:59

cts

726d6fc

Apply suggestions from code review

26a7363

Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>

liuxingbaoyu force-pushed the eslint-parser-cts branch from 210fc52 to bf4d83a Compare January 21, 2024 05:17

use ts next

2773358

liuxingbaoyu force-pushed the eslint-parser-cts branch from bf4d83a to 2773358 Compare January 21, 2024 05:21

liuxingbaoyu commented Jan 21, 2024

View reviewed changes

JLHwung reviewed Jan 22, 2024

View reviewed changes

nicolo-ribaudo mentioned this pull request Jan 23, 2024

5.4 breaks @types/node when using isolatedModules microsoft/TypeScript#57136

Closed

update

8303fce

JLHwung approved these changes Jan 25, 2024

View reviewed changes

nicolo-ribaudo approved these changes Jan 25, 2024

View reviewed changes

export types

7dc1928

nicolo-ribaudo approved these changes Jan 25, 2024

View reviewed changes

nicolo-ribaudo merged commit b2bbffb into babel:main Jan 25, 2024
50 checks passed

liuxingbaoyu added a commit to liuxingbaoyu/babel that referenced this pull request Mar 5, 2024

Migrate eslint-parser to cts (babel#16222)

6dfb11c

Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>

github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Apr 26, 2024

github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate `eslint-parser` to cts #16222

Migrate `eslint-parser` to cts #16222

liuxingbaoyu commented Jan 18, 2024

babel-bot commented Jan 18, 2024 •

edited

babel-bot commented Jan 18, 2024

liuxingbaoyu commented Jan 18, 2024

nicolo-ribaudo Jan 18, 2024

nicolo-ribaudo Jan 18, 2024

liuxingbaoyu Jan 21, 2024

liuxingbaoyu commented Jan 21, 2024

liuxingbaoyu Jan 21, 2024

nicolo-ribaudo Jan 22, 2024 •

edited

JLHwung Jan 22, 2024

Semigradsky Jan 23, 2024 •

edited

nicolo-ribaudo Jan 24, 2024

JLHwung Jan 22, 2024

nicolo-ribaudo Jan 25, 2024

liuxingbaoyu Jan 25, 2024 •

edited

nicolo-ribaudo Jan 25, 2024

Migrate eslint-parser to cts #16222

Migrate eslint-parser to cts #16222

Conversation

liuxingbaoyu commented Jan 18, 2024

babel-bot commented Jan 18, 2024 • edited

babel-bot commented Jan 18, 2024

liuxingbaoyu commented Jan 18, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

liuxingbaoyu commented Jan 21, 2024

Choose a reason for hiding this comment

nicolo-ribaudo Jan 22, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Semigradsky Jan 23, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

liuxingbaoyu Jan 25, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Migrate `eslint-parser` to cts #16222

Migrate `eslint-parser` to cts #16222

babel-bot commented Jan 18, 2024 •

edited

nicolo-ribaudo Jan 22, 2024 •

edited

Semigradsky Jan 23, 2024 •

edited

liuxingbaoyu Jan 25, 2024 •

edited