Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use descriptors for private class elements #16261

Merged
merged 2 commits into from Feb 7, 2024
Merged

Do not use descriptors for private class elements #16261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f74d4de
Do not use descriptors for private class elements
nicolo-ribaudo Feb 2, 2024
323d29f
Rename isAccessor to isGetterOrSetter
nicolo-ribaudo Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
4 changes: 2 additions & 2 deletions Makefile.js
View file
Open in desktop

Large diffs are not rendered by default.

9 changes: 9 additions & 0 deletions Makefile.source.mjs
View file
Open in desktop
Expand Up @@ -459,6 +459,15 @@ target["new-version-checklist"] = function () {
Update minVersion in packages/babel-helpers/src/helpers/applyDecs2311.ts
!!!!!! Write any important message here, and change the !!!!!!
!!!!!! if (0) above to if (1) !!!!!!
- Update the version:
- assertClassBrand
- classPrivateFieldGet2
- classPrivateFieldSet2
- classPrivateGetter
- classPrivateSetter
- toSetter
!!!!!! !!!!!!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
Expand Down