Improve output when privateFieldsAsProperties or privateFieldsAsSymbols
#16313
Conversation
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/56537 |
liuxingbaoyu
force-pushed
the
improve-classPrivateFieldLooseBase
branch
from
30d7bd8
to
9c4e868
Compare
liuxingbaoyu
added
the
PR: Output optimization 🔬
liuxingbaoyu
force-pushed
the
improve-classPrivateFieldLooseBase
branch
from
c1f929e
to
b7ae29b
Compare
| @@ -893,6 +893,15 @@ helpers.classPrivateFieldLooseBase = helper("7.0.0-beta.0")` | |||
| } | |||
| `; | |||
|
|
|||
| helpers.classPrivateFieldGetLoose = helper("7.24.0")` | |||
There was a problem hiding this comment.
Can you move it to a standalone file? :)
| babelHelpers.classPrivateFieldLooseBase(this, _foo)[_foo] = 2; | ||
| babelHelpers.classPrivateFieldLooseBase(other.obj, _foo)[_foo] += 1; | ||
| babelHelpers.classPrivateFieldLooseBase(other.obj, _foo)[_foo] = 2; | ||
| babelHelpers.classPrivateFieldGetLoose(this, _foo, 1)[_foo] += 1; |
There was a problem hiding this comment.
Isn't this a size increase in general? It looks shorter because the helepr name is shorter, but once you minify the helper name to 1 char this has ,1 more.
There was a problem hiding this comment.
Maybe we can pass ,1 to mean "return the property" rather than "return the receiver", so that we are sure that it's an improbement rather than depending on the ratio of get to set.
| @@ -839,6 +839,13 @@ const privateNameHandlerLoose: Handler<PrivateNameState> = { | |||
| const { object } = member.node; | |||
| const { name } = (member.node.property as t.PrivateName).id; | |||
|
|
|||
| if (process.env.BABEL_8_BREAKING || newHelpers(file)) { | |||
There was a problem hiding this comment.
newHelpers doesn't work here anymore, because it returns true in 7.24.0
There was a problem hiding this comment.
ah. I have modified newHelpers to return true in v7.24.1. Maybe the changes were lost for some reason.
What do you think of this approach?
| @@ -3,7 +3,7 @@ var _privateStaticMethod = /*#__PURE__*/babelHelpers.classPrivateFieldLooseKey(" | |||
| class Cl { | |||
| constructor() { | |||
| if (exfiltrated === undefined) { | |||
| exfiltrated = babelHelpers.classPrivateFieldLooseBase(Cl, _privateStaticMethod)[_privateStaticMethod]; | |||
| exfiltrated = babelHelpers.classPrivateFieldGetLoose(Cl, _privateStaticMethod); | |||
There was a problem hiding this comment.
For methods, when the receiver is the class name, we can skip the helper call (similarly to how we do for the non-loose transform)
There was a problem hiding this comment.
Unfortunately this will cause the test to fail. :)
liuxingbaoyu
force-pushed
the
improve-classPrivateFieldLooseBase
branch
from
b7ae29b
to
c701ff0
Compare
liuxingbaoyu
force-pushed
the
improve-classPrivateFieldLooseBase
branch
from
c701ff0
to
b6821f7
Compare
liuxingbaoyu
force-pushed
the
improve-classPrivateFieldLooseBase
branch
from
b6821f7
to
005dd59
Compare
Fixes #1, Fixes #2attempted to use private field on non-instanceis now replaced by throwingTypeError: this[_privateMethod] is not a function, which I think does not matter since this is not inspecmode.Contains #16312, please only view the last commit, it does not require blocking release.