Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix decorator evaluation private environment #16325

Merged
merged 27 commits into from Mar 6, 2024
Merged

Fix decorator evaluation private environment #16325

merged 27 commits into from Mar 6, 2024

Commits on Mar 5, 2024

  1. enable field-initializers-after-methods-private test

    @JLHwung
    JLHwung committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    198e865 View commit details
    Browse the repository at this point in the history

  2. refactor: extract computed key memoisation

    @JLHwung
    JLHwung committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    06aea1a View commit details
    Browse the repository at this point in the history

  3. handle computed static field in decorated class

    @JLHwung
    JLHwung committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    c30a189 View commit details
    Browse the repository at this point in the history

  4. handle this and super call when moving computed key assignments

    @JLHwung
    JLHwung committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    782505c View commit details
    Browse the repository at this point in the history

  5. handle other functional context

    @JLHwung
    JLHwung committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    6dd3198 View commit details
    Browse the repository at this point in the history

  6. fix: insert non-static class in the key of the wrapper 

    This change ensures that 1) non static computed key will share the same function context when moved into the non-static class 2) evaluations of decorators and computed keys will always precede static computed keys, given that they have been moved into computed key assignments before
    @JLHwung
    JLHwung committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    2d34eeb View commit details
    Browse the repository at this point in the history

  7. inject computed keys elements to the last non-comptued elements 

    so that we can still preserve the production params [yield], [await] inherited from the outer scope
    @JLHwung
    JLHwung committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    125a837 View commit details
    Browse the repository at this point in the history

  8. reorg complex AST factories

    @JLHwung
    JLHwung committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    efbce42 View commit details
    Browse the repository at this point in the history

  9. add new test cases

    @JLHwung
    JLHwung committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    7714626 View commit details
    Browse the repository at this point in the history

  10. copy test cases to 2023-11-misc--to-es-2015

    @JLHwung
    JLHwung committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    4ce976c View commit details
    Browse the repository at this point in the history

  11. update test outputs

    @JLHwung
    JLHwung committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    713ad4c View commit details
    Browse the repository at this point in the history

  12. rewrite findLast usage for legacy node support

    @JLHwung
    JLHwung committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    bf86824 View commit details
    Browse the repository at this point in the history

  13. make old node happy

    @JLHwung
    JLHwung committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    fff405f View commit details
    Browse the repository at this point in the history

  14. fix: use temp class fields to host decorator expr

    @JLHwung
    JLHwung committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    f4314e5 View commit details
    Browse the repository at this point in the history

  15. add class-in-for-loop test

    @JLHwung
    JLHwung committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    2cd5bcc View commit details
    Browse the repository at this point in the history

  16. fix: skip decorators and key when replacing super within a class method

    @JLHwung
    JLHwung committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    707b91c View commit details
    Browse the repository at this point in the history

  17. copy tests to es2015

    @JLHwung
    JLHwung committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    f62c5c2 View commit details
    Browse the repository at this point in the history

  18. address review comments

    @JLHwung
    JLHwung committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    6969fd4 View commit details
    Browse the repository at this point in the history

  19. fix ts errors

    @JLHwung
    JLHwung committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    4c9c493 View commit details
    Browse the repository at this point in the history

  20. enable the lastPublicElement insertion point for other decorator vers… 

    …ions
    @JLHwung
    JLHwung committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    bdee20d View commit details
    Browse the repository at this point in the history

  21. update test output

    @JLHwung
    JLHwung committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    d33d87b View commit details
    Browse the repository at this point in the history

  22. ensure typescript test works in both Babel 8 and Babel 7

    @JLHwung
    JLHwung committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    7ad03e3 View commit details
    Browse the repository at this point in the history

  23. make old node happy

    @JLHwung
    JLHwung committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    ccb441a View commit details
    Browse the repository at this point in the history

  24. workaround pushContainer AST sync issue

    @JLHwung
    JLHwung committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    9073384 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. small tweaks 

    - rename some routines
- improve originalClassPath access, to avoid a full traversal
- add more jsdoc coments
    @JLHwung
    JLHwung committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    af8caa6 View commit details
    Browse the repository at this point in the history

  2. output: inject computed key assignments in the first public element

    @JLHwung
    JLHwung committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    e856f3c View commit details
    Browse the repository at this point in the history

  3. update test output

    @JLHwung
    JLHwung committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    20426d6 View commit details
    Browse the repository at this point in the history