Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Capture let when the for body is not a block #16368

Merged
merged 2 commits into from Mar 20, 2024

Conversation

liuxingbaoyu
Copy link
Member

Q                       A
Fixed Issues? Fixes #16367
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass?
Documentation PR Link
Any Dependency Changes?
License MIT

@liuxingbaoyu liuxingbaoyu changed the title fix: Capture let when for does not follow a block fix: Capture let when for does not follow a block Mar 20, 2024
@liuxingbaoyu liuxingbaoyu added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Mar 20, 2024
@babel-bot
Copy link
Collaborator

babel-bot commented Mar 20, 2024

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/56562

@nicolo-ribaudo nicolo-ribaudo changed the title fix: Capture let when for does not follow a block fix: Capture let when the for body is not a block Mar 20, 2024
Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an exec.js test?

@nicolo-ribaudo nicolo-ribaudo merged commit 3956c75 into babel:main Mar 20, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: local let variable is not captured in for..in loop
4 participants