Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect numeric-seperator tests #16381

Merged
merged 1 commit into from Mar 25, 2024

Conversation

Dunqing
Copy link
Contributor

@Dunqing Dunqing commented Mar 25, 2024

The tests must be in the second level directory, with the first level directory being suite.
So this test packages/babel-plugin-transform-numeric-separator/test/fixtures/used-with-transform-es2015-literals test does not work for a long time.

Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/56571

Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nicolo-ribaudo nicolo-ribaudo merged commit acf3d17 into babel:main Mar 25, 2024
51 checks passed
@nicolo-ribaudo
Copy link
Member

Thank you!

Dunqing pushed a commit to oxc-project/oxc that referenced this pull request Mar 26, 2024
This PR updates the babel submodule in the justfile to take advantage of
[this PR](babel/babel#16381). Related to #2795
and #2797.
charnog pushed a commit to charnog/oxc that referenced this pull request Mar 26, 2024
This PR updates the babel submodule in the justfile to take advantage of
[this PR](babel/babel#16381). Related to oxc-project#2795
and oxc-project#2797.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants