Fix suppressed error order #16440
Fix suppressed error order #16440
Conversation
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/56739 |
|
Sure! I re-run make build and committed the additional files. |
| @@ -13,7 +13,7 @@ function helper(minVersion: string, source: string) { | |||
| } | |||
|
|
|||
| export default Object.freeze({ | |||
| // size: 1126, gzip size: 512 | |||
| // size: 1126, gzip size: 511 | |||
There was a problem hiding this comment.
I suspect the node.js in your environment is installed by homebrew, which links to the latest zlib version 1.3.1. Can you post the result of node -e "console.log(process.versions.zlib)"?
For reference, it prints 1.2.13.1-motley-5daffc7 for the official Node.js 20 build.
There was a problem hiding this comment.
When I type node -e "console.log(process.versions.zlib)", it says 1.2.13.1-motley.
liuxingbaoyu
added
PR: Bug Fix 🐛
|
Thanks @nicolo-ribaudo, @JLHwung . Although it is a small task and I received a lot of help, this is a great motivation and accomplishment for me. I will grow into a better developer. |
|
If you want to contribute more we are also happy to help! For example, #16422 is also related to explicit resource management (but it's about how we transform code, rather than the runtime helper). |
The order in which errors are passed to the SuppressedError constructor has been changed.