Bump glob to 10.3.12

[JLHwung]

Q	A
Fixed Issues?	Bump glob to 10.3.12 for Babel 8
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass?	Yes
Documentation PR Link
Any Dependency Changes?
License	MIT

New options are added to maintain the glob 7 behaviour. The import is changed so that it works for both glob 7 + CJS and glob 10 + ESM scenario. There should be no behaviour changes for babel-cli users.

We can't ship this PR for Babel 7 as glob 9 dropped Node < 14 support.

[nicolo-ribaudo]

Suggested change

	if (process.env.BABEL_8_BREAKING) {
	// glob 9+ no longer sorts the result, here we maintain the glob 7 behaviour
	// https://github.com/isaacs/node-glob/blob/c3cd57ae128faa0e9190492acc743bb779ac4054/common.js#L151
	// eslint-disable-next-line no-var
	var files = globSync(input, { dotRelative: true }).sort(
	function alphasort(a, b) {
	return a.localeCompare(b, "en");
	},
	);
	} else {
	files = globSync(input);
	}
	let files = globSync(input, { dotRelative: true });
	if (process.env.BABEL_8_BREAKING) {
	// glob 9+ no longer sorts the result, here we maintain the glob 7 behaviour
	// https://github.com/isaacs/node-glob/blob/c3cd57ae128faa0e9190492acc743bb779ac4054/common.js#L151
	files.sort(
	function alphasort(a, b) {
	return a.localeCompare(b, "en");
	},
	);
	}

Curious if this works (to avoid var in the Babel 8 code, minimizing the manual changes when we'll codemod away process.env.BABEL_8_BREAKING).

[JLHwung]

It does work technically since glob 7 does not validate its options, as dotRelative was added in glob 9.1.

[babel-bot]

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/56791

[nicolo-ribaudo]

Suggested change

	"glob": "condition:BABEL_8_BREAKING ? ^10.3.12 : ^7.2.0",
	"glob": "condition:BABEL_8_BREAKING ? ^10.3.12 : ^7.2.0 (esm:sync)",

this should fix CI

[JLHwung]

Thanks. I just figured out the same change from the conditionParser.ts.

[nicolo-ribaudo]

Instead of using the plugin, would this work?

import * as glob from "glob";

Suggested change

	let files = process.env.BABEL_8_BREAKING
	? // glob 9+ no longer sorts the result, here we maintain the glob 7 behaviour
	// https://github.com/isaacs/node-glob/blob/c3cd57ae128faa0e9190492acc743bb779ac4054/common.js#L151
	globSync(input, { dotRelative: true }).sort(function alphasort(a, b) {
	return a.localeCompare(b, "en");
	})
	: globSync(input);
	let files = process.env.BABEL_8_BREAKING
	? // glob 9+ no longer sorts the result, here we maintain the glob 7 behaviour
	// https://github.com/isaacs/node-glob/blob/c3cd57ae128faa0e9190492acc743bb779ac4054/common.js#L151
	(USE_ESM ? glob.default : glob).sync(input, { dotRelative: true }).sort(function alphasort(a, b) {
	return a.localeCompare(b, "en");
	})
	: glob.sync(input);

[JLHwung]

The USE_ESM branch should be moved to the Babel 7, otherwise it looks good to me, I will give it a try.