Use the real sourcemap API and handle input sourcemaps - fixes T7259 #3456
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does two things:
._mappings
sourceFileName
to set thesource
value on the sourcemaps generated by Babel, rather than overriding the values.2 here is a behavior change / new feature depending on how you look at it. It means input sourcemaps will actually work. Before, if you had an input sourcemap, we would basically use the mappings from it, but then discard them and pretend the mapping was actually for the JS file given to Babel to compile, which would produce incorrect final sourcemaps.
The dramatic size reduction in the test output file in this example is actually because of our use of
result.actual
, because it contained an input sourcemap, and at this stage it was not stripped out. By relying on Babel to set the source name and content, we allow Babel's internal logic to strip off the input sourcemap properly.