Add support for the new declare module.exports of flow. #3570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.space(); | ||
| this.word("module"); | ||
| this.token("."); | ||
| this.word("exports"); |
There was a problem hiding this comment.
Is this the right way to print module.exports? Do I need to care about spacing?
Current coverage is 88.24% (diff: 100%)@@ master #3570 diff @@
==========================================
Files 191 191
Lines 13579 13597 +18
Methods 1422 1426 +4
Messages 0 0
Branches 3125 3128 +3
==========================================
+ Hits 11981 11999 +18
Misses 1598 1598
Partials 0 0
|
hzoo
added
PR: New Feature 🚀
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the new node DeclareClassModule. I'm not sure about my changes in the generator, see inline comments.
I also did not make an entry in babel-types/retrievers.js as I did not know what to put there as
DeclareModuleExportsdoes not have an id. Is this necessary?(tests will fail as the parser is not updated yet)
relates to babel/babylon#72