Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #6726 ignore config option #3644

Merged

Conversation

subtleGradient
Copy link
Contributor

@codecov-io
Copy link

codecov-io commented Aug 8, 2016

Current coverage is 88.13% (diff: 100%)

Merging #3644 into master will not change coverage

@@             master      #3644   diff @@
==========================================
  Files           188        188          
  Lines         10924      10924          
  Methods        1162       1162          
  Messages          0          0          
  Branches       2492       2492          
==========================================
  Hits           9628       9628          
  Misses         1296       1296          
  Partials          0          0          

Powered by Codecov. Last update a2d66c0...87f7d04

@STRML
Copy link
Contributor

STRML commented Aug 21, 2016

This is a really annoying bug and contradicts the docs. Could someone please review and merge it ASAP?

@quantizor
Copy link

@hzoo ?

@hzoo
Copy link
Member

hzoo commented Aug 23, 2016

So sorry for the delay, I'm not particularly familiar with this of the codebase but @kittens says it was probably an artifact of some older code at the time. 67201e9

I think it's leftover from when babel.transform didn't actually return if a file was ignroed
so if we left it up to babel.transform then we'd just return the code verbatim and wouldn't do anything to it and we'd write it to the file system

@hzoo hzoo merged commit 2a4186f into babel:master Aug 23, 2016
@hzoo hzoo added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Aug 23, 2016
@gcedo
Copy link

gcedo commented Sep 26, 2016

I am continuing to experience this bug, babel-cli@6.14.0. Now the ignore option is supported, but files are not ignored recursively.

E.g., declaring:

"ignore": [
        "node_modules"
]

Will cause the build to fail anyway because, as babel will try to transpile files deep down in the node_modules hierarchy:

69% 1206/1215 build modulesnode_modules/babel-plugin-react-transform/lib/index.js -> dist/node_modules/babel-plugin-react-transform/lib/index.js

@danez
Copy link
Member

danez commented Sep 26, 2016

@gcedo Does it work if you specify the option on the command line?

babel --ignore 'node_modules' ... 

@gcedo
Copy link

gcedo commented Sep 26, 2016

Yes, it does. As I have seen the bug fix I have moved the options in .babelrc, but now it fails 😢

@danez
Copy link
Member

danez commented Sep 26, 2016

Can you please open a new issue, so we do not forget about it. Thanks

@pdillon
Copy link

pdillon commented Oct 11, 2016

@danez Opened #4707 and corresponding PR #4708

@cula
Copy link

cula commented Apr 25, 2017

Happen again on babel 6.24.0

@thabti
Copy link

thabti commented Jan 27, 2018

happens on 6.26.0

MartijnHols added a commit to WoWAnalyzer/WoWAnalyzer that referenced this pull request Mar 11, 2018
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label May 2, 2018
@lock lock bot locked as resolved and limited conversation to collaborators May 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants