Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Guy Fieri from Babel's source code #3646

Merged
merged 1 commit into from Aug 15, 2016
Merged

Remove Guy Fieri from Babel's source code #3646

merged 1 commit into from Aug 15, 2016
+0 −193

Conversation

jdan
Copy link
Contributor

@jdan jdan commented Aug 9, 2016

I brought you into this world, and I can take you out of it.

@jdan
Revert "Merge pull request babel#3641 from babel/guy-fieri"
7dabeb4 
This reverts commit 033681a, reversing
changes made to a2d66c0.

I brought you into this world, and I can take you out.
@hzoo
Copy link
Member

hzoo commented Aug 9, 2016

Thank you 😸

@hzoo
Copy link
Member

hzoo commented Aug 9, 2016

All part of the plan - thanks for your first Babel PR!

@dudeOFprosper
Copy link

👎

@codecov-io
Copy link

codecov-io commented Aug 9, 2016 •
edited

Current coverage is 88.13% (diff: 100%)

No coverage report found for master at 033681a.

Powered by Codecov. Last update 033681a...7dabeb4

@hzoo hzoo added this to the Next Patch milestone Aug 9, 2016
@zloirock
Copy link
Member

zloirock commented Aug 9, 2016

Nope, I use it in my projects. It's breaking change and requires major bump.

@hzoo hzoo modified the milestones: Next Major, Next Patch Aug 9, 2016
@hzoo
Copy link
Member

hzoo commented Aug 9, 2016

Babel 7: remove Guy Fieri

@hzoo hzoo added PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release and removed PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release labels Aug 9, 2016
@hzoo hzoo removed this from the Next Major milestone Aug 9, 2016
@robotmayo
Copy link

This would break my code that relies on being taken to flavortown.

@JosephClay
Copy link

Fairly certain that all my unit tests check for guy before proceeding.

@stevemao
Copy link
Contributor

stevemao commented Aug 9, 2016

No HELL please!

@sebmck
Copy link
Contributor

sebmck commented Aug 9, 2016

Joke pull requests are not appreciated. @jdan Thank you for your contribution but we cannot accept this as its a semver major version change.

@sebmck sebmck closed this Aug 9, 2016
@jamiebuilds
Copy link
Contributor

👐
♨️
🎤

@azu azu mentioned this pull request Aug 10, 2016
Closed
@hernandev
Copy link

I would never discover codecov.io but for this joke! thank you guys, keep the world funny!

@yupferris yupferris mentioned this pull request Aug 15, 2016
Closed
@hzoo hzoo mentioned this pull request Aug 15, 2016
Merged
@hzoo hzoo reopened this Aug 15, 2016
@hzoo hzoo merged commit ca27cf1 into babel:master Aug 15, 2016
@sebmck
Copy link
Contributor

sebmck commented Aug 15, 2016

no fun allowed

@ultrafez ultrafez mentioned this pull request Aug 15, 2016
Closed
@babel babel locked and limited conversation to collaborators Aug 15, 2016
@hzoo
Copy link
Member

hzoo commented Aug 16, 2016

😄

@hzoo hzoo added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Aug 23, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet