System.register update expression consistency #3650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guybedford
force-pushed
the
system-register-export-post-assignment
branch
from
4a8d6f0
to
bd46f8d
Compare
Current coverage is 88.13% (diff: 100%)
|
hzoo
added
the
PR: Bug Fix 🐛
|
Cool, wondering if this only an issue for systemjs? |
|
Yes this is just for SystemJS output. Thanks for merging! |
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that update expressions like
x++andx--, wherexis an exported binding, get replaced with the expression_export('x', x - 1), x--and_export('x, x + 1), x++respectively.The reason for this is that we need the expression to provide the same outward value, while reporting the correct value for the export binding to the setter functions.
This then allows standard exported counter scenarios to work correctly.