Strip flow-only class props without needing transform-class-properties. #3655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 88.13% (diff: 100%)@@ master #3655 diff @@
==========================================
Files 188 188
Lines 10925 10925
Methods 1162 1162
Messages 0 0
Branches 2492 2492
==========================================
Hits 9629 9629
Misses 1296 1296
Partials 0 0
|
|
@loganfsmyth looks good. Do we want to add a test for the other case in the logic (a class property with annotation that only removes the annotation)? |
hzoo
added
the
PR: Bug Fix 🐛
This was referenced Sep 7, 2016
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternate fix for #3654