Use arrow syntax for ObjectTypeProperty FunctionTypeAnnotations #3663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where optional properties would get transformed to an invalid syntax. The easiest solution was to make all FunctionTypes get transformed to the arrow syntax (previously everything went the other way).
|
Filed https://phabricator.babeljs.io/T7564 with a few more details. |
Current coverage is 88.22% (diff: 100%)@@ master #3663 diff @@
==========================================
Files 191 191
Lines 13603 13598 -5
Methods 1424 1424
Messages 0 0
Branches 3131 3129 -2
==========================================
- Hits 12002 11997 -5
Misses 1601 1601
Partials 0 0
|
|
Interesting - lgtm? |
hzoo
added
the
PR: Bug Fix 🐛
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where optional properties would get transformed to
an invalid syntax. The easiest solution was to make all FunctionTypes
get transformed to the arrow syntax (previously everything went the
other way).