Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not include babel-register in test helper #3669

Merged
merged 2 commits into from Sep 24, 2016
Merged

Do not include babel-register in test helper #3669

merged 2 commits into from Sep 24, 2016

Conversation

danez
Copy link
Member

@danez danez commented Aug 22, 2016

Seems this is not needed for the internal tests? Not sure if this might be used outside of babel and break stuff there?

I discovered that while debugging the pirates integration and was curious why we do this, although not needed. Anybody knows?

@danez danez added the PR: Internal 🏠 A type of pull request used for our changelog categories label Aug 22, 2016
@hzoo
Copy link
Member

hzoo commented Aug 22, 2016

Yeah I was getting this issue before, but I thought this was transpiling the required tests? Not sure @kittens

@codecov-io
Copy link

codecov-io commented Aug 22, 2016

Current coverage is 88.47% (diff: 100%)

Merging #3669 into master will increase coverage by 0.12%

@@             master      #3669   diff @@
==========================================
  Files           194        192     -2   
  Lines         13624      13491   -133   
  Methods        1427       1412    -15   
  Messages          0          0          
  Branches       3151       3126    -25   
==========================================
- Hits          12037      11936   -101   
+ Misses         1587       1555    -32   
  Partials          0          0          

Powered by Codecov. Last update d7533e8...5e8c6f5

@danez
Copy link
Member Author

danez commented Sep 24, 2016

By looking more at it it seems to ignore anyway everything (node_modules and ./packages/)

{
  ignore: [
    path.resolve(__dirname + "/../.."),
    "node_modules",
  ]
}

And we don't have code or tests outside of that.

I'm going to merge these and will keep an eye on this after the release, I tested with some external projects that use this module, but couldn't find any usecase.

@danez danez merged commit d6f4d85 into master Sep 24, 2016
@danez danez deleted the babel-cleanup branch September 24, 2016 12:51
@hzoo
Copy link
Member

hzoo commented Sep 24, 2016

This means we can remove the babel-register dep?

@danez
Copy link
Member Author

danez commented Sep 24, 2016

Oh ups, forgot that

panagosg7 pushed a commit to panagosg7/babel that referenced this pull request Jan 17, 2017
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants