Allow overwritting of sourceRoot #3685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danez
added
the
PR: Bug Fix 🐛
|
I don't think we've really used Object.assign in the codebase (although it is covered by transform-runtime) - lodash.extend/merge should work too right? |
Also replaces lodash/extend with Object.assign
|
Yes right, noticed that myself. Was for some reason thinking it gets transpiled by babel. Reverted that. |
|
There is http://babeljs.io/docs/plugins/transform-object-assign/, but yeah polyfill. Might even try to remove runtime from the packages if we don't use it |
Current coverage is 88.28% (diff: 100%)
|
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue raised here: https://phabricator.babeljs.io/rBC54115fbdae875206e4ef6f0e76c7132568045ea4
This change allows sourceRoot to be overwritten.