Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused packages (devDeps) #3693

Merged
merged 4 commits into from Sep 2, 2016
Merged

remove unused packages (devDeps) #3693

merged 4 commits into from Sep 2, 2016

Conversation

hzoo
Copy link
Member

@hzoo hzoo commented Sep 1, 2016

After seeing #3692

@danez

@danez
Copy link
Member

danez commented Sep 1, 2016

Its probably okay, couldn't find any usages either.

@codecov-io
Copy link

codecov-io commented Sep 1, 2016

Current coverage is 88.32% (diff: 100%)

Merging #3693 into master will not change coverage

@@             master      #3693   diff @@
==========================================
  Files           194        194          
  Lines         13611      13611          
  Methods        1427       1427          
  Messages          0          0          
  Branches       3142       3142          
==========================================
  Hits          12022      12022          
  Misses         1589       1589          
  Partials          0          0          

Powered by Codecov. Last update 2664c16...0cd9a2a

@hzoo
Copy link
Member Author

hzoo commented Sep 1, 2016

noo merge conflict

@hzoo hzoo force-pushed the remove-unused branch 2 times, most recently from ab9b0ec to f3c130e Compare September 2, 2016 03:43
@hzoo
Copy link
Member Author

hzoo commented Sep 2, 2016

We can run eslint on tests after we make it so we can write es2015 in tests

@hzoo hzoo added the PR: Internal 🏠 A type of pull request used for our changelog categories label Sep 2, 2016
@hzoo hzoo changed the title remove unused packages remove unused packages (devDeps) Sep 2, 2016
@hzoo hzoo merged commit d81e154 into master Sep 2, 2016
@hzoo hzoo deleted the remove-unused branch September 2, 2016 12:44
@hzoo hzoo mentioned this pull request Oct 12, 2016
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants