Computed class properties #4500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
** Depends on babel/babylon#121 ** * `babel-types`: Add `computed` field to `ClassProperty` * `babel-plugin-transform-class-properties`: handle computed property names correctly * `babel-generator`: add tests for class properties (computed/literal, static/instance)
motiz88
added a commit
to motiz88/babel-plugin-transform-hoist-nested-functions
that referenced
this pull request
Sep 11, 2016
…ue`) See README.md for documentation. This feature is blocked on the following Babel PRs/issues: * babel/babel#4500 * babel/babylon#121 * babel/babel#4337 * babel/babel#4230 (partially)
hzoo
added
PR: New Feature 🚀
|
2: If there is no builder entry in the type it defaults to visitors: https://github.com/babel/babel/blob/master/packages/babel-types/src/definitions/index.js#L135 This is definitely a breaking change, would it be okey to make computes the last argument? |
Current coverage is 88.38% (diff: 100%)@@ master #4500 diff @@
==========================================
Files 194 194
Lines 13628 13635 +7
Methods 1427 1427
Messages 0 0
Branches 3152 3155 +3
==========================================
+ Hits 12041 12051 +10
+ Misses 1587 1584 -3
Partials 0 0
|
danez
approved these changes
Sep 24, 2016
|
thanks. |
|
@danez can make an issue for that |
panagosg7
pushed a commit
to panagosg7/babel
that referenced
this pull request
Jan 17, 2017
* Support computed class property names (babel#4499) ** Depends on babel/babylon#121 ** * `babel-types`: Add `computed` field to `ClassProperty` * `babel-plugin-transform-class-properties`: handle computed property names correctly * `babel-generator`: add tests for class properties (computed/literal, static/instance) * doc: Update babel-types with ClassProperty.computed * chore(package): update babylon to v6.11.0 * babel-types: move ClassProperty.computed to be last builder arg
motiz88
added a commit
to motiz88/babel-plugin-transform-hoist-nested-functions
that referenced
this pull request
Apr 2, 2017
…ue`) See README.md for documentation. This feature is blocked on the following Babel PRs/issues: * babel/babel#4500 * babel/babylon#121 * babel/babel#4337 * babel/babel#4230 (partially)
motiz88
added a commit
to motiz88/babel-plugin-transform-hoist-nested-functions
that referenced
this pull request
Apr 2, 2017
…ue`) See README.md for documentation. This feature is blocked on the following Babel PRs/issues: * babel/babel#4500 * babel/babylon#121 * babel/babel#4337 * babel/babel#4230 (partially)
motiz88
added a commit
to motiz88/babel-plugin-transform-hoist-nested-functions
that referenced
this pull request
Apr 2, 2017
…ue`) See README.md for documentation. This feature is blocked on the following Babel PRs/issues: * babel/babel#4500 * babel/babylon#121 * babel/babel#4337 * babel/babel#4230 (partially)
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(but see note2)babel-typesREADME only)Comments on the above table
1: As a first-time contributor it's kinda hard for me to classify this change 😄
It tracks a roughly year-old update to a stage 2 proposal (tc39/proposal-class-public-fields), which is otherwise already implemented.
2:
I suppose the addition ofSuperseded by the latest commit per @danez's suggestion.computedas the third (and not last) builder argument in babel-types/src/definitions/flow.js#L47 may be considered a breaking change to clients of that package (but what was the behavior there in the absence of thebuilderproperty, anyway?). I'll happily change it to whatever you people prefer.3: I did not add tests for my changes to
babel-types, because I could not find any existing tests for this package. (Am I missing something?)4: The full test suite doesn't run to completion on my Windows dev machine, but what did run seems OK.
Notes on the change
Depends on babel/babylon#121 which has been released in Babylon v6.11.0.
Changes to individual modules:
babel-types: Addcomputedfield toClassPropertybabel-plugin-transform-class-properties: handle computed property names correctlybabel-generator: add tests for class properties (computed/literal, static/instance)