Remove ES2015 tests than do not parse in ES2016 #4501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests are originally from Traceur, which does not fully support ES2016. See babel/babylon#106 for a rationale why these code blocks are not valid ES2016.
Current coverage is 88.32% (diff: 100%)@@ master #4501 diff @@
==========================================
Files 194 194
Lines 13609 13609
Methods 1426 1426
Messages 0 0
Branches 3145 3145
==========================================
Hits 12020 12020
Misses 1589 1589
Partials 0 0
|
hzoo
added
PR: Spec Compliance 👓
|
Thanks! |
panagosg7
pushed a commit
to panagosg7/babel
that referenced
this pull request
Jan 17, 2017
These tests are originally from Traceur, which does not fully support ES2016. See babel/babylon#106 for a rationale why these code blocks are not valid ES2016.
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test fragments contain code that are valid ES2015 programs, but not valid ES2016 ones (they were originally from Traceur, which does not fully support ES2016). To support the ES2016 semantics in Babylon (babel/babylon#106), these tests must be removed.
Specifically, per e.g. ECMA-262 7th Edition § 14.1.2:
Similar clauses cover arrow functions, methods, and generator functions/methods, as well as async functions and async arrow functions.