Only set options in cli if different from default #4507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danez
added
the
PR: Bug Fix 🐛
danez
changed the title
danez
changed the title
Current coverage is 88.32% (diff: 100%)@@ master #4507 diff @@
==========================================
Files 194 194
Lines 13612 13612
Methods 1427 1427
Messages 0 0
Branches 3146 3146
==========================================
Hits 12023 12023
Misses 1589 1589
Partials 0 0
|
Currently default values (like comments: true) will be set always for the transform. This behaviour dos not allow for setting this options from babelrc as the default would always have precedence.
Also ensure that the babelrc in the fixture folder is copied over to the working directory during tests
danez
force-pushed
the
danez-cli-options
branch
from
7e5227f
to
604fad1
Compare
danez
changed the title
|
👍 Awesome! This should fix babel/minify#67 too? |
|
Yes. Not sure though how we should do the "remove only none important comments", but that's an other issue anyway. |
|
Yeah we should make another issue if not already |
panagosg7
pushed a commit
to panagosg7/babel
that referenced
this pull request
Jan 17, 2017
* CLI: Only set options if different from default Currently default values (like comments: true) will be set always for the transform. This behaviour dos not allow for setting this options from babelrc as the default would always have precedence. * Add new tests for comments Also ensure that the babelrc in the fixture folder is copied over to the working directory during tests
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently default values (like
comments: true) will be set always for the transform.This behaviour does not allow for setting this options from babelrc as the default would always have precedence.
This is WIP, I still want to write tests and find all related issues.