Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom ports for V8 --inspect #4508

Merged
merged 1 commit into from Sep 12, 2016
Merged

Conversation

andykant
Copy link
Contributor

@andykant andykant commented Sep 12, 2016

Q A
Bug fix? yes
Breaking change? no
New feature? no
Deprecations? no
Spec compliancy? no
Tests added/pass? no
Fixed tickets comma-separated list of tickets fixed by the PR, if any
License MIT
Doc PR reference to the documentation PR, if any

When support for V8's --inspect was added in #3578, it added support for inspection with only the default port. This prevents multiple inspection instances from being open simultaneously.

This tweak adds support for --inspect=PORT, so that custom ports can be used as well.

@codecov-io
Copy link

Current coverage is 88.32% (diff: 100%)

Merging #4508 into master will not change coverage

@@             master      #4508   diff @@
==========================================
  Files           194        194          
  Lines         13612      13612          
  Methods        1427       1427          
  Messages          0          0          
  Branches       3146       3146          
==========================================
  Hits          12023      12023          
  Misses         1589       1589          
  Partials          0          0          

Powered by Codecov. Last update 41f2bbc...6e38d67

@danez
Copy link
Member

danez commented Sep 12, 2016

Thanks 👍

@danez danez added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Sep 12, 2016
@danez danez added this to the Next Patch milestone Sep 12, 2016
@danez danez merged commit 5e9e659 into babel:master Sep 12, 2016
panagosg7 pushed a commit to panagosg7/babel that referenced this pull request Jan 17, 2017
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants