Fix UpdateExpression handling in es2015-modules-commonjs, resolve #4462 #4511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 88.44% (diff: 100%)
|
|
cc @loganfsmyth |
hzoo
added
the
PR: Bug Fix 🐛
|
original PR was done in #3368 |
|
Also saw this and was wondering. Send to not do anything right now. But maybe it was meant that the function should actually return something. |
|
Looks good. Obviously that |
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
requeueInParentcall is apparently redundant (all tests pass without it). Also, whatever it was meant to do, I don't believe it has ever worked - sincereplaceWithMultiplereturnsundefinedand has done so since basically forever (so theforwould always have caused an error).Possibly some other requeue calls in this file can be omitted with no adverse effects, but I kept changes to a minimum.